jackwener commented on code in PR #7795:
URL: https://github.com/apache/arrow-datafusion/pull/7795#discussion_r1360151197
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -48,16 +48,17 @@ impl std::fmt::Debug for RowCursor {
impl RowCursor {
/// Create a new SortKeyCursor from `rows` and a `reservation`
- /// that tracks its memory.
+ /// that tracks its memory. Thre must be at least one row
Review Comment:
```suggestion
/// that tracks its memory. There must be at least one row
```
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -48,16 +48,17 @@ impl std::fmt::Debug for RowCursor {
impl RowCursor {
/// Create a new SortKeyCursor from `rows` and a `reservation`
- /// that tracks its memory.
+ /// that tracks its memory. Thre must be at least one row
///
/// Panic's if the reservation is not for exactly `rows.size()`
Review Comment:
```suggestion
/// Panics if the reservation is not for exactly `rows.size()`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
