js8544 commented on PR #38116: URL: https://github.com/apache/arrow/pull/38116#issuecomment-1771399596
Ok, I saw the issue here... I thought we agreed on approach 1 in https://github.com/apache/arrow/pull/38116#discussion_r1365205400 and will refactor to approach 2 for all the global instances in Gandiva in a separate PR. That's why I'm comparing different ways to implement the global state. I definitely agree that apprach 2 is better and am not against having it right here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
