felipecrv commented on issue #38186: URL: https://github.com/apache/arrow/issues/38186#issuecomment-1776464717
> No, I would say part of this PR would be refactoring UnboxValue to return a failing `Result` if the value were not the expected JSON type. Isn't that going to add considerable overhead? The point of these `DCHECKs` is documenting the pre-conditions of these functions. In release builds we should test the type only on the caller, not on caller and on the `ARROW_CHECK`. Perhaps we should document them and their callers with proper `/// \pre ...` Doxygen pre-conditions and fix any code violating the pre-conditions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
