bkietz commented on code in PR #37792:
URL: https://github.com/apache/arrow/pull/37792#discussion_r1372311116
##########
cpp/src/arrow/integration/json_internal.cc:
##########
@@ -106,6 +107,13 @@ std::string GetTimeUnitName(TimeUnit::type unit) {
return "UNKNOWN";
}
+Result<std::string_view> GetStringView(const rj::Value& str) {
+ if (!str.IsString()) {
+ return Status::Invalid("field was not a string line ", __LINE__);
Review Comment:
I'll remove the `__LINE__`. EXTRA_ERROR_CONTEXT will add the line numbers
and more for the sites which call this, so no need to restate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
