lidavidm commented on PR #1227:
URL: https://github.com/apache/arrow-adbc/pull/1227#issuecomment-1780128324

   ok
   
   ```go
                ctx, err = cl.Client.AuthenticateBasicToken(ctx, d.user, 
d.pass, grpc.Header(&header), grpc.Trailer(&trailer), d.timeout)
                if err != nil {
                        return nil, adbcFromFlightStatusWithDetails(err, 
header, trailer, "AuthenticateBasicToken")
                }
   
                if md, ok := metadata.FromOutgoingContext(ctx); ok {
                        // No need to worry about lock here since we are sole 
owner
                        authMiddle.hdrs.Set("authorization", 
md.Get("Authorization")[0])
                }
   ```
   
   I think this comment is wrong? Since we're using the client right before 
this so maybe the middleware is still running asynchronously


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to