thinkharderdev commented on code in PR #4999:
URL: https://github.com/apache/arrow-rs/pull/4999#discussion_r1374748745
##########
object_store/src/aws/builder.rs:
##########
@@ -299,6 +301,15 @@ pub enum AmazonS3ConfigKey {
/// Skip signing request
SkipSignature,
+ /// Skips tagging objects
+ ///
+ /// This can be desirable if not supported by the backing store
+ ///
+ /// Supported keys:
+ /// - `aws_skip_tagging`
+ /// - `skip_tagging`
+ SkipTagging,
Review Comment:
Maybe `DisableTagging`
##########
object_store/src/aws/builder.rs:
##########
@@ -299,6 +301,15 @@ pub enum AmazonS3ConfigKey {
/// Skip signing request
SkipSignature,
+ /// Skips tagging objects
+ ///
+ /// This can be desirable if not supported by the backing store
+ ///
+ /// Supported keys:
+ /// - `aws_skip_tagging`
+ /// - `skip_tagging`
+ SkipTagging,
Review Comment:
but I don't feel strongly either :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
