tustvold commented on code in PR #4918:
URL: https://github.com/apache/arrow-rs/pull/4918#discussion_r1374884987
##########
object_store/src/aws/client.rs:
##########
@@ -58,30 +58,12 @@ const VERSION_HEADER: &str = "x-amz-version-id";
#[derive(Debug, Snafu)]
#[allow(missing_docs)]
pub(crate) enum Error {
- #[snafu(display("Error performing get request {}: {}", path, source))]
Review Comment:
These variants simply acted as an indirection to source.error, see
https://github.com/apache/arrow-rs/pull/4918/commits/e4af13759dcff891b29789e0d9ea8c259c5887a2#diff-0feb099a0931110c214fa9b9c8c5528512f38ebf22448772a815baee5973b8c4L147
It is simpler to skip this indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
