jduo commented on code in PR #38469:
URL: https://github.com/apache/arrow/pull/38469#discussion_r1374972057
##########
docs/source/java/flight_sql_jdbc_driver.rst:
##########
@@ -115,18 +115,20 @@ parameters are:
- When TLS is enabled, the password for the certificate store
* - useEncryption
- - false
- - Whether to use TLS (the default is an insecure, plaintext
- connection)
+ - true
Review Comment:
Hmm, all parameters should be camelCase per:
https://github.com/apache/arrow/blob/547b2406d71bf9ad14e2bcc7064c6923165dd737/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/ArrowFlightConnectionConfigImpl.java#L168
and
https://github.com/apache/arrow/blob/547b2406d71bf9ad14e2bcc7064c6923165dd737/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/ArrowFlightConnectionConfigImpl.java#L202
Though the get() implementation seems to also allow fully lower-case. It's
probably supposed to be case-insensitive though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
