sgilmore10 commented on PR #38459: URL: https://github.com/apache/arrow/pull/38459#issuecomment-1783433919
> Thanks for working through all of the feedback I provided, @leihou6116! Overall, this is looking really nice! > > I just made a few more suggestions based on the latest changes. > > One high-level piece of feedback is that I think the ordering of the sections feels a bit confusing at the moment. > > Perhaps, we could order them as follows: > > 1. Overview > 2. Prerequisites > 3. MATLAB Class-Based Unit Testing Framework > 4. Running Tests Locally > 5. Writing tests > 6. General Guidelines > 7. Test Organization > 8. Continuous Integration (CI) Workflows > 9. Code Coverage Goals > 10. How to Check Code Coverage > 11. Tips My two cent would be to switch `Running Tests Locally` and `MATLAB Class-Based Unit Testing Framework` around. If you do that, you might even be able to delete `MATLAB Class-Based Unit Testing Framework` since the `Writing tests` section also discusses the framework to use when writing MATLAB tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
