alamb commented on code in PR #7940:
URL: https://github.com/apache/arrow-datafusion/pull/7940#discussion_r1375013520
##########
.github/workflows/rust.yml:
##########
@@ -68,6 +71,12 @@ jobs:
- name: Check workspace without default features
run: cargo check --no-default-features -p datafusion
+ - name: Check tests in each package
+ run: |
+ for package in $(cargo metadata --no-deps --format-version 1 | jq
-r '.packages[].name'); do
+ cargo check --tests --package "$package" || exit 1
+ done
Review Comment:
I think this command verifies that `cargo test --package "$package"` will
compile successfully, but it doesn't check if `cargo test --no-default-features
--package "$package"` would run successfully
But I am not sure how common running `cargo test --no-default-features
--package "$package"` is 🤔
##########
.github/workflows/rust.yml:
##########
@@ -68,6 +71,12 @@ jobs:
- name: Check workspace without default features
run: cargo check --no-default-features -p datafusion
+ - name: Check tests in each package
+ run: |
+ for package in $(cargo metadata --no-deps --format-version 1 | jq
-r '.packages[].name'); do
+ cargo check --tests --package "$package" || exit 1
+ done
Review Comment:
I think this command verifies that `cargo test --package "$package"` will
compile successfully, but it doesn't check if `cargo test --no-default-features
--package "$package"` would run successfully
But I am not sure how common running `cargo test --no-default-features
--package "$package"` is 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
