eeroel commented on PR #37868: URL: https://github.com/apache/arrow/pull/37868#issuecomment-1783802985
> Thanks for this. Can you add a test that this succeeds when the right size is passed? Perhaps on the C++ side, instead of only in Python? Added a test on the Python side but where do you think would be a good place for the C++ test? There are already these tests from the original implementation, but do you mean we should also write something that tests the path from FileSource creation onwards? https://github.com/apache/arrow/commit/4f8504f28877995ed179e35b077e6df6c14cac9c#diff-5748697423aff1b6f4688662b451378684a3ba0e1d3b13a8eca267925e3afb39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
