tustvold opened a new issue, #5019: URL: https://github.com/apache/arrow-rs/issues/5019
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.** <!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] (This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*) --> Currently `PathPart::parse` and by extension `Path::parse` disallow paths containing "unsafe" characters. This feels unnecessarily puritanical given: * Most stores and filesystems do actually support UTF-8 * We don't exclude characters that some filesystems don't support, e.g. `:` on Mac OSX * We don't exclude filenames that are forbidden on some systems, e.g. `COM1` on Windows * We exclude characters that are fairly common, e.g. `~` * We actually add `%` characters to paths, which the stores recommend against including in object names **Describe the solution you'd like** <!-- A clear and concise description of what you want to happen. --> I think we should preserve the existing percent encoding behaviour when using the infallible methods, this gives people a safe default behaviour. However, I would propose we change `PathPart::parse` to only reject segments that * Are `""` or `"."` or `".."` * Contain ASCII control characters * Contain a delimiter This broadly conforms to what is supported by most filesystems - https://en.wikipedia.org/wiki/Filename **Describe alternatives you've considered** <!-- A clear and concise description of any alternative solutions or features you've considered. --> **Additional context** <!-- Add any other context or screenshots about the feature request here. --> https://github.com/apache/arrow-datafusion/pull/8014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
