Jefffrey commented on code in PR #8062:
URL: https://github.com/apache/arrow-datafusion/pull/8062#discussion_r1383157509


##########
datafusion/core/src/datasource/file_format/json.rs:
##########
@@ -258,10 +258,16 @@ impl DisplayAs for JsonSink {
 }
 
 impl JsonSink {
-    fn new(config: FileSinkConfig) -> Self {
+    /// Create from config.
+    pub fn new(config: FileSinkConfig) -> Self {
         Self { config }
     }
 
+    /// Retrieve the inner [`FileSinkConfig`].
+    pub fn config(&self) -> &FileSinkConfig {
+        &self.config
+    }
+

Review Comment:
   Need to expose these as public for proto to be able to create them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to