jonahgao commented on code in PR #8083:
URL: https://github.com/apache/arrow-datafusion/pull/8083#discussion_r1385275186
##########
datafusion/expr/src/aggregate_function.rs:
##########
@@ -411,3 +411,23 @@ impl AggregateFunction {
}
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use strum::IntoEnumIterator;
+
+ #[test]
+ // Test for AggregateFuncion's Display and from_str() implementations.
+ // For each variant in AggregateFuncion, it converts the variant to a
string
+ // and then back to a variant. The test asserts that the original variant
and
+ // the reconstructed variant are the same.
+ fn test_display_and_from_str() {
Review Comment:
This test is mostly copied from the test for `BuiltinScalarFunction`.
https://github.com/apache/arrow-datafusion/blob/f3c9009e50fdb5811c522bfb07ba29ac04cd1d22/datafusion/expr/src/built_in_function.rs#L1625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
