jduo commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1385412559
########## cpp/src/arrow/flight/sql/server_session_middleware.cc: ########## @@ -0,0 +1,179 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/flight/sql/server_session_middleware.h" +#include <boost/lexical_cast.hpp> +#include <boost/uuid/uuid.hpp> +#include <boost/uuid/uuid_generators.hpp> +#include <boost/uuid/uuid_io.hpp> Review Comment: There are many UUID libraries available, but there are a limited number that work as well as boost. Most do not randomize with 128-bits of precision (see this discussion: https://stackoverflow.com/questions/24365331/how-can-i-generate-uuid-in-c-without-using-boost-library). Others have a C++17 requirement -- would that be OK to use in the Arrow project? [crossguid](https://github.com/graeme-hill/crossguid) utilizes operating system calls for generating UUIDs so it should generate them securely enough. It supports Windows, Mac, Linux, and Android -- is this enough platform support for Arrow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
