viirya commented on code in PR #8085: URL: https://github.com/apache/arrow-datafusion/pull/8085#discussion_r1385787821
########## docs/source/contributor-guide/index.md: ########## @@ -222,7 +222,7 @@ Below is a checklist of what you need to do to add a new scalar function to Data - a new line in `create_physical_expr`/`create_physical_fun` mapping the built-in to the implementation - tests to the function. - In [core/tests/sqllogictests/test_files](../../../datafusion/core/tests/sqllogictests/test_files), add new `sqllogictest` integration tests where the function is called through SQL against well known data and returns the expected result. Review Comment: ```suggestion - In [sqllogictest/test_files](../../../datafusion/sqllogictest/test_files), add new `sqllogictest` integration tests where the function is called through SQL against well known data and returns the expected result. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
