joellubi commented on code in PR #38385:
URL: https://github.com/apache/arrow/pull/38385#discussion_r1387821303
##########
cpp/src/arrow/flight/sql/types.h:
##########
@@ -119,6 +119,14 @@ struct ARROW_FLIGHT_SQL_EXPORT SqlInfoOptions {
/// If 0, there is no timeout.
FLIGHT_SQL_SERVER_TRANSACTION_TIMEOUT = 101,
+ /// Retrieves a boolean value indicating whether the Flight SQL Server
+ /// supports executing bulk ingestion.
+ FLIGHT_SQL_SERVER_BULK_INGESTION = 102,
+
+ /// Retrieves a boolean value indicating whether the Flight SQL Server
+ /// supports transactions for bulk ingestion.
+ FLIGHT_SQL_SERVER_INGEST_TRANSACTIONS_SUPPORTED = 103,
Review Comment:
I read through the [PR](https://github.com/apache/arrow/pull/13492) where
the enum keys 9 and 100 were originally defined but couldn't find an explicit
reason. The keys added in this PR seem to make sense in the 0-500 range but I'm
not sure whether they should be added after 9 or after 101. Any context on this
@lidavidm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
