alamb commented on code in PR #8094:
URL: https://github.com/apache/arrow-datafusion/pull/8094#discussion_r1387852930
##########
datafusion/core/src/datasource/statistics.rs:
##########
@@ -70,7 +70,11 @@ pub async fn get_statistics_with_limit(
// files. This only applies when we know the number of rows. It also
// currently ignores tables that have no statistics regarding the
// number of rows.
- if num_rows.get_value().unwrap_or(&usize::MIN) <=
&limit.unwrap_or(usize::MAX) {
+ let conservative_num_rows = match num_rows {
Review Comment:
👍
##########
datafusion/core/src/datasource/statistics.rs:
##########
@@ -70,7 +70,11 @@ pub async fn get_statistics_with_limit(
// files. This only applies when we know the number of rows. It also
// currently ignores tables that have no statistics regarding the
// number of rows.
- if num_rows.get_value().unwrap_or(&usize::MIN) <=
&limit.unwrap_or(usize::MAX) {
+ let conservative_num_rows = match num_rows {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
