edmondop commented on issue #94: URL: https://github.com/apache/arrow-datafusion/issues/94#issuecomment-1811027180
> Hi @OscarTHZhang Thanks for commenting on this ticket. > > > I think we can divide the micro-bench into 2 types (as described above) > > I think the core goal for the ticket is to ensure the vast majority of the time is spent doing the operation rather than reading data. > > It might make sense to go through existing benchmarks and try to see what coverage we already have > > End to end benchmarks: [`master`/benchmarks](https://github.com/apache/arrow-datafusion/tree/master/benchmarks?rgh-link-date=2022-08-09T11%3A59%3A02Z) > > more micro level benchmarks: [`master`/datafusion/core/benches](https://github.com/apache/arrow-datafusion/tree/master/datafusion/core/benches?rgh-link-date=2022-08-09T11%3A59%3A02Z) > > There are already some benchmarks that appear to be _Targeted SQL_ that you describe, for example [`master`/datafusion/core/benches/sql_planner.rs](https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/sql_planner.rs?rgh-link-date=2022-08-09T11%3A59%3A02Z) and [`master`/datafusion/core/benches/aggregate_query_sql.rs](https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/aggregate_query_sql.rs?rgh-link-date=2022-08-09T11%3A59%3A02Z) > > There are also some benchmarks for operators that are used as part of other operations, such as [`master`/datafusion/core/benches/merge.rs](https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/merge.rs?rgh-link-date=2022-08-09T11%3A59%3A02Z) @alamb the way this issue title is phrased, it seems the right way to address is to extend the benchmarks which you shared here as micro-benchmarks. [master/datafusion/core/benches](https://github.com/apache/arrow-datafusion/tree/master/datafusion/core/benches?rgh-link-date=2022-08-09T11%3A59%3A02Z) is that correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
