vleslief-ms commented on code in PR #1274: URL: https://github.com/apache/arrow-adbc/pull/1274#discussion_r1394728721
########## csharp/test/Drivers/Snowflake/ValueTests.cs: ########## @@ -0,0 +1,257 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +using System; +using System.Collections.Generic; +using System.Data.SqlTypes; +using Apache.Arrow.Adbc.Tests.Drivers.Interop.Snowflake; +using Apache.Arrow.Ipc; +using Apache.Arrow.Types; +using Xunit; + +namespace Apache.Arrow.Adbc.Tests +{ + // TODO: When supported, use prepared statements instead of SQL string literals + // Which will better test how the driver handles values sent/received + + public class ValueTests + { + static readonly string s_testTablePrefix = "ADBCVALUETEST_"; // Make configurable? Also; must be all caps if not double quoted + readonly SnowflakeTestConfiguration _snowflakeTestConfiguration; + readonly AdbcConnection _connection; + readonly AdbcStatement _statement; + readonly string _catalogSchema; + + /// <summary> + /// Validates that specific numeric values can be inserted, retrieved and targeted correctly + /// </summary> + public ValueTests() + { + if (Utils.CanExecuteTestConfig(SnowflakeTestingUtils.SNOWFLAKE_TEST_CONFIG_VARIABLE)) + { + _snowflakeTestConfiguration = Utils.LoadTestConfiguration<SnowflakeTestConfiguration>(SnowflakeTestingUtils.SNOWFLAKE_TEST_CONFIG_VARIABLE); + Dictionary<string, string> parameters = new(); + Dictionary<string, string> options = new(); + AdbcDriver snowflakeDriver = SnowflakeTestingUtils.GetSnowflakeAdbcDriver(_snowflakeTestConfiguration, out parameters); + AdbcDatabase adbcDatabase = snowflakeDriver.Open(parameters); + _connection = adbcDatabase.Connect(options); + _statement = _connection.CreateStatement(); + _catalogSchema = string.Format("{0}.{1}", _snowflakeTestConfiguration.Metadata.Catalog, _snowflakeTestConfiguration.Metadata.Schema); + } + } + + /// <summary> + /// Validates if driver can send and receive specific Integer values correctly + /// These Snowflake types are equivalent: NUMBER(38,0),INT,INTEGER,BIGINT,SMALLINT,TINYINT,BYTEINT + /// </summary> + [SkippableFact] + public void TestIntegerRange() + { + string columnName = "INTTYPE"; + string table = CreateTemporaryTable(string.Format("{0} INT", columnName)); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, -1); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 0); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 1); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MinValue); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MaxValue); + } + + /// <summary> + /// Validates if driver can handle smaller Number type correctly + /// </summary> + [SkippableFact] + public void TestSmallNumberRange() + { + string columnName = "SMALLNUMBER"; + string table = CreateTemporaryTable(string.Format("{0} NUMBER(2,0)", columnName)); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, -1); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 0); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 1); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, -99); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 99); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MinValue)); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MaxValue)); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, -100)); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 100)); + } + + /// <summary> + /// Validates if driver can handle a large scale Number type correctly + /// </summary> + [SkippableFact] + public void TestLargeScaleNumberRange() + { + string columnName = "LARGESCALENUMBER"; + string table = CreateTemporaryTable(string.Format("{0} NUMBER(38,37)", columnName)); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 0); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("-2.0003")); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("4.85")); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("0.0000000000000000000000000000000000001")); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("9.5545204502636499875576383003668916798")); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("-10"))); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("10"))); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MinValue)); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MaxValue)); + } + + /// <summary> + /// Validates if driver can handle a large scale Number type correctly + /// </summary> + [SkippableFact] + public void TestSmallScaleNumberRange() + { + string columnName = "SMALLSCALENUMBER"; + string table = CreateTemporaryTable(string.Format("{0} NUMBER(38,2)", columnName)); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, 0); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("4.85")); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("-999999999999999999999999999999999999.99")); + ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.Parse("999999999999999999999999999999999999.99")); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MinValue)); + Assert.Throws<AdbcException>(() => ValidateInsertSelectDeleteSingleDecimalValue(table, columnName, SqlDecimal.MaxValue)); + + // Snowflake allows insert when input goes beyond scale, but storage will round value. + // Round up test + InsertSingleValue(table, columnName, "2.467"); + SelectAndValidateValues(table, columnName, SqlDecimal.Parse("2.47"), 1); + DeleteFromTable(table, string.Format("{0}={1}", columnName, SqlDecimal.Parse("2.47")), 1); + // Round down test + InsertSingleValue(table, columnName, "-672.613"); + SelectAndValidateValues(table, columnName, SqlDecimal.Parse("-672.61"), 1); + DeleteFromTable(table, string.Format("{0}={1}", columnName, SqlDecimal.Parse("-672.61")), 1); + } + + /// <summary> + /// Validates if driver can handle floating point number type correctly + /// These Snowflake types are equivalent: FLOAT,FLOAT4,FLOAT8,DOUBLE,DOUBLE PRECISION,REAL + /// </summary> + [SkippableFact] + public void TestFloatNumberRange() + { + string columnName = "FLOATTYPE"; + string table = CreateTemporaryTable(string.Format("{0} FLOAT", columnName)); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, 0); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, double.NegativeInfinity); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, double.PositiveInfinity); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, double.MaxValue); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, double.MinValue); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, double.NaN); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, 0.2); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, 15e-03); + ValidateInsertSelectDeleteSingleDoubleValue(table, columnName, 1.234E+2); + } + + private void ValidateInsertSelectDeleteSingleDecimalValue(string table, string columnName, SqlDecimal value) + { + InsertSingleValue(table, columnName, value.ToString()); + SelectAndValidateValues(table, columnName, value, 1); + DeleteFromTable(table, string.Format("{0}={1}", columnName, value), 1); + } + + private void ValidateInsertSelectDeleteSingleDoubleValue(string table, string columnName, double value) + { + string valueString = ConvertDoubleToString(value); + InsertSingleValue(table, columnName, valueString); + SelectAndValidateValues(table, columnName, value, 1); + DeleteFromTable(table, string.Format("{0}={1}", columnName, valueString), 1); + } + + private void InsertSingleValue(string table, string columnName, string value) + { + string insertNumberStatement = string.Format("INSERT INTO {0} ({1}) VALUES ({2});", table, columnName, value); + Console.WriteLine(insertNumberStatement); + _statement.SqlQuery = insertNumberStatement; + UpdateResult updateResult = _statement.ExecuteUpdate(); + Assert.Equal(1, updateResult.AffectedRows); + } + + private static string ConvertDoubleToString(double value) + { + switch (value) + { + case double.PositiveInfinity: + return "'inf'"; + case double.NegativeInfinity: + return "'-inf'"; + case double.NaN: + return "'NaN'"; + default: + return value.ToString(); + } + } + + private async void SelectAndValidateValues(string table, string columnName, object value, int count) + { + string selectNumberStatement; + if (value.GetType() == typeof(double)) + { + selectNumberStatement = string.Format("SELECT {0} FROM {1} WHERE {0}={2};", columnName, table, ConvertDoubleToString((double)value)); Review Comment: > I just pushed up > > https://github.com/apache/arrow-adbc/blob/864da786febf2768c6de2ffdde74f424936badf2/csharp/test/Drivers/Snowflake/SnowflakeData.cs#L34 > > . It's a different approach to being able to return data and compare the expected values. But this code has other interesting traits like running a DELETE command. I'm using temporary tables now which would remove the need for any "DELETE"s. I'm thinking it may be worth testing INSERT and DELETE FROM just because it would be useful to see how a value from the client and driver is stored by the data source, and whether it can be targeted correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
