lidavidm commented on PR #38385:
URL: https://github.com/apache/arrow/pull/38385#issuecomment-1814539236
enums should still follow Protobuf convention, so it should be
```
enum TableNotExistOption {
// Do not use. Servers should error if this is specified by a client.
TABLE_NOT_EXIST_OPTION_UNSPECIFIED = 0;
// ...
TABLE_NOT_EXIST_OPTION_CREATE = 1;
TABLE_NOT_EXIST_OPTION_FAIL = 2;
}
```
> Does this all align with your understanding and what you intended? Also,
should we remove optional from temporary? That way temporary is automatically
interpreted as false when unset instead of handling it in the code.
IMO, `optional` in Protobuf is purely semantics for the human reader. It
will still default to `false`. (It also changes codegen to expose a flag.) We
can remove it, but it by no means needs to be set either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
