comphead commented on code in PR #8252:
URL: https://github.com/apache/arrow-datafusion/pull/8252#discussion_r1397590871
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -389,88 +325,46 @@ fn array_array(args: &[ArrayRef], data_type: DataType) ->
Result<ArrayRef> {
return plan_err!("Array requires at least one argument");
}
- let res = match data_type {
- DataType::List(..) => {
- let row_count = args[0].len();
- let column_count = args.len();
- let mut list_arrays = vec![];
- let mut list_array_lengths = vec![];
- let mut list_valid = BooleanBufferBuilder::new(row_count);
- // Construct ListArray per row
- for index in 0..row_count {
- let mut arrays = vec![];
- let mut array_lengths = vec![];
- let mut valid = BooleanBufferBuilder::new(column_count);
- for arg in args {
- if arg.as_any().downcast_ref::<NullArray>().is_some() {
- array_lengths.push(0);
- valid.append(false);
- } else {
- let list_arr = as_list_array(arg)?;
- let arr = list_arr.value(index);
- array_lengths.push(arr.len());
- arrays.push(arr);
- valid.append(true);
- }
- }
- if arrays.is_empty() {
- list_valid.append(false);
- list_array_lengths.push(0);
- } else {
- let buffer = valid.finish();
- // Assume all list arrays have the same data type
- let data_type = arrays[0].data_type();
- let field = Arc::new(Field::new("item",
data_type.to_owned(), true));
- let elements = arrays.iter().map(|x|
x.as_ref()).collect::<Vec<_>>();
- let values = compute::concat(elements.as_slice())?;
- let list_arr = ListArray::new(
- field,
- OffsetBuffer::from_lengths(array_lengths),
- values,
- Some(NullBuffer::new(buffer)),
- );
- list_valid.append(true);
- list_array_lengths.push(list_arr.len());
- list_arrays.push(list_arr);
- }
+ let mut data = vec![];
+ let mut total_len = 0;
+ for arg in args {
+ let arg_data = if arg.as_any().is::<NullArray>() {
+ ArrayData::new_empty(&data_type)
+ } else {
+ arg.to_data()
+ };
+ total_len += arg_data.len();
+ data.push(arg_data);
+ }
+ let mut offsets = Vec::with_capacity(total_len);
+ offsets.push(0);
+
+ let capacity = Capacities::Array(total_len);
+ let data_ref = data.iter().collect::<Vec<_>>();
+ let mut mutable = MutableArrayData::with_capacities(data_ref, true,
capacity);
+
+ let num_rows = args[0].len();
Review Comment:
Please make sure args is not empty, before accessing the element by index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
