wgtmac commented on code in PR #38784:
URL: https://github.com/apache/arrow/pull/38784#discussion_r1398685486
##########
cpp/src/parquet/encoding.cc:
##########
@@ -1205,6 +1209,9 @@ struct ArrowBinaryHelper<ByteArrayType> {
return Status::OK();
}
+ // If estimated_remaining_data_length is provided, it will also Reserve the
estimated
Review Comment:
```suggestion
// If estimated_remaining_data_length is provided, it will also reserve
the estimated
```
##########
cpp/src/parquet/encoding.cc:
##########
@@ -1196,6 +1196,10 @@ struct ArrowBinaryHelper<ByteArrayType> {
chunk_space_remaining_(::arrow::kBinaryMemoryLimit -
acc_->builder->value_data_length()) {}
+ // Prepare will Reserve the number of entries remaining in the current chunk.
Review Comment:
```suggestion
// Prepare will reserve the number of entries remaining in the current
chunk.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
