jayzhan211 commented on code in PR #8279:
URL: https://github.com/apache/arrow-datafusion/pull/8279#discussion_r1399909183
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -1044,6 +1044,20 @@ select make_array(['a','b'], null);
----
[[a, b], ]
+## array_sort (aliases: `list_sort`)
+query ???
+select array_sort(make_array(4, 2, 3, 1)), array_sort(make_array(1.0, 4.0,
null, 3.0), true, true), array_sort(make_array('a', 'd', 'c', null, 'b'),
false, false);
Review Comment:
btw, you can also try column-wise support, pass the test with `table`, you
can refer other array_function that run with `table`. But it is fine for me to
support that in follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
