Dandandan commented on code in PR #8289:
URL: https://github.com/apache/arrow-datafusion/pull/8289#discussion_r1400504049
##########
datafusion/physical-plan/src/insert.rs:
##########
@@ -219,24 +219,17 @@ impl ExecutionPlan for FileSinkExec {
}
fn required_input_ordering(&self) ->
Vec<Option<Vec<PhysicalSortRequirement>>> {
- // The input order is either exlicitly set (such as by a ListingTable),
- // or require that the [FileSinkExec] gets the data in the order the
- // input produced it (otherwise the optimizer may chose to reorder
- // the input which could result in unintended / poor UX)
- //
- // More rationale:
- //
https://github.com/apache/arrow-datafusion/pull/6354#discussion_r1195284178
- match &self.sort_order {
Review Comment:
We experienced some problems with this as well (added sorts), so happy to
see this go :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
