Tangruilin commented on code in PR #5078:
URL: https://github.com/apache/arrow-rs/pull/5078#discussion_r1401504423
##########
arrow-cast/src/parse.rs:
##########
@@ -544,6 +544,18 @@ const EPOCH_DAYS_FROM_CE: i32 = 719_163;
/// Error message if nanosecond conversion request beyond supported interval
const ERR_NANOSECONDS_NOT_SUPPORTED: &str = "The dates that can be represented
as nanoseconds have to be between 1677-09-21T00:12:44.0 and
2262-04-11T23:47:16.854775804";
+fn parse_two_digit_year(input_year: i32) -> i32 {
Review Comment:
> FWIW https://www.rfc-editor.org/rfc/rfc3339#section-3 explicitly disallows
2 digit years as they are ambiguous
It refer to https://www.postgresql.org/docs/current/datatype-datetime.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
