Weijun-H commented on code in PR #8290:
URL: https://github.com/apache/arrow-datafusion/pull/8290#discussion_r1401991558
##########
datafusion/common/src/scalar.rs:
##########
@@ -342,7 +346,38 @@ impl PartialOrd for ScalarValue {
None
}
}
+ (LargeList(arr1), LargeList(arr2)) => {
+ if arr1.data_type() == arr2.data_type() {
+ let list_arr1 = as_large_list_array(arr1);
+ let list_arr2 = as_large_list_array(arr2);
+ if list_arr1.len() != list_arr2.len() {
+ return None;
+ }
+ for i in 0..list_arr1.len() {
Review Comment:
I will work on this on next PR
##########
datafusion/common/src/scalar.rs:
##########
@@ -342,7 +346,38 @@ impl PartialOrd for ScalarValue {
None
}
}
+ (LargeList(arr1), LargeList(arr2)) => {
+ if arr1.data_type() == arr2.data_type() {
+ let list_arr1 = as_large_list_array(arr1);
+ let list_arr2 = as_large_list_array(arr2);
+ if list_arr1.len() != list_arr2.len() {
+ return None;
+ }
+ for i in 0..list_arr1.len() {
Review Comment:
I will work on this on the next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
