jayzhan211 commented on code in PR #8317:
URL: https://github.com/apache/arrow-datafusion/pull/8317#discussion_r1404759553


##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -181,7 +239,7 @@ fn coerced_from<'a>(
         Int64
             if matches!(
                 type_from,
-                Null | Int8 | Int16 | Int32 | Int64 | UInt8 | UInt16 | UInt32
+                Null | Int8 | Int16 | Int32 | Int64 | UInt8 | UInt16 | UInt32 
| Boolean

Review Comment:
   Only i64 is fix for passing existing test in array.slt. More type should be 
fixed in https://github.com/apache/arrow-datafusion/issues/8302



##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -181,7 +239,7 @@ fn coerced_from<'a>(
         Int64
             if matches!(
                 type_from,
-                Null | Int8 | Int16 | Int32 | Int64 | UInt8 | UInt16 | UInt32
+                Null | Int8 | Int16 | Int32 | Int64 | UInt8 | UInt16 | UInt32 
| Boolean

Review Comment:
   Only i64 is fixrf for passing existing test in array.slt. More type should 
be fixed in https://github.com/apache/arrow-datafusion/issues/8302



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to