fatemehp commented on issue #38880: URL: https://github.com/apache/arrow/issues/38880#issuecomment-1826380563
data page filter should not be set with V1 repeated fields. This is because we do not have num_rows in DataPageStats for V1 repeated fields. So the stats that the callback is called with is not helpful in that case anyways. We should add a comment in the code. Note that the set_data_page_filter API is marked experimental. On Fri, Nov 24, 2023 at 10:35 PM mwish ***@***.***> wrote: > cc @emkornfield <https://github.com/emkornfield> @fatemehp > <https://github.com/fatemehp> > > I think this might not be triggered when page-index enabled, but would > this be a problem in v1 page with cross-page record? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/issues/38880#issuecomment-1826231196>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABOHYRYD2QCZJN3NX5C2YRDYGGGTRAVCNFSM6AAAAAA7Z4K2ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGIZTCMJZGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
