jayzhan211 commented on code in PR #8313:
URL: https://github.com/apache/arrow-datafusion/pull/8313#discussion_r1405517728
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -2514,6 +2520,67 @@ mod tests {
.is_null(0));
}
+ #[test]
+ fn test_array_range() {
Review Comment:
@alamb @Weijun-H
There is one problem actually, function like `align_array_dimensions` we
have a unit test for it but it is not possible to port to slt file. We should
either not test it directly but rely on array function test that call it or
port it to datafusion::common::utils, and test it there. I think the latter is
better so we can check the coverage more easily.
btw, should we introduce array_utils in common. I think it will grow larger
and larger quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
