jduo commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r1407385966
##########
java/memory/memory-netty/pom.xml:
##########
@@ -68,5 +75,25 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>memory-jdk11+</id>
+ <activation>
+ <jdk>[11,]</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <compilerArgs combine.children="append">
+
<arg>--patch-module=io.netty.buffer=${project.basedir}/../memory-netty-buffer-patch/target/arrow-memory-netty-buffer-patch-${project.version}.jar</arg>
Review Comment:
@davisusanibar , I'm having problems getting this step to run in the new PR
and am not entirely sure if it is necessary.
The new PR just does a pure syntax compilation of module-info.java so it
doesn't verify the dependencies listed and just uses the classpath to look for
classes from arrow-memory-netty-buffer-patch.
Was this step added so that this module would correctly find classes in
io.netty.buffer defined in arrow-memory-netty-buffer-patch at build-time only,
or does this have an effect at run time? My reading online is that even if we
used patch-module to compile, a user utilizing the module would still need to
use patch-module to specify module extensions to netty.
If patch-module is only used here to help get this JAR to compile, it seems
like it isn't necessary in the new PR since the plugin is compiling
module-info.java without verifying its imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
