alamb commented on code in PR #8316:
URL: https://github.com/apache/arrow-datafusion/pull/8316#discussion_r1407708514
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -771,31 +295,6 @@ async fn
count_distinct_integers_aggregated_multiple_partitions() -> Result<()>
Ok(())
}
-#[tokio::test]
-async fn aggregate_with_alias() -> Result<()> {
Review Comment:
this looks like a dataframe test -- I'll port it over to
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/dataframe/mod.rs
as a follow on PR
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -1327,46 +1327,173 @@ select avg(c1), arrow_typeof(avg(c1)) from d_table
----
5 Decimal128(14, 7)
-# FIX: different test table
+
# aggregate
-# query I
-# SELECT SUM(c1), SUM(c2) FROM test
-# ----
-# 60 220
+query II
+SELECT SUM(c1), SUM(c2) FROM test
+----
+7 6
Review Comment:
This gets a different answer (likely because the table is different).
However, I think the test still offers the same coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
