bkietz commented on code in PR #37868:
URL: https://github.com/apache/arrow/pull/37868#discussion_r1408021740
##########
python/pyarrow/_dataset.pyx:
##########
@@ -96,27 +96,33 @@ def _get_parquet_symbol(name):
return _dataset_pq and getattr(_dataset_pq, name)
-cdef CFileSource _make_file_source(object file, FileSystem filesystem=None):
+cdef CFileSource _make_file_source(object file, FileSystem filesystem=None,
int64_t file_size=-1):
Review Comment:
Huh, I didn't know that was disallowed for cdef functions... maybe it makes
parsing pointer args harder?
Re the default arg, I made this metaPR
https://github.com/eeroel/arrow/pull/1 which compiled and passed your test case
on my machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
