kou commented on code in PR #38926:
URL: https://github.com/apache/arrow/pull/38926#discussion_r1408553378
##########
ci/conan/all/conanfile.py:
##########
@@ -328,7 +328,7 @@ def _with_boost(self, required=False):
return bool(self.options.with_boost)
def _with_thrift(self, required=False):
- # No self.options.with_thift exists
+ # No self.options.with_thrift exists
Review Comment:
Could you report this to the upstream?
https://github.com/conan-io/conan-center-index/blob/master/recipes/arrow/all/conanfile.py
##########
ci/conan/all/test_package/test_package.cpp:
##########
@@ -78,7 +78,7 @@ arrow::Status VectorToColumnarTable(const std::vector<struct
data_row>& rows,
// Indicate the start of a new list row. This will memorise the current
// offset in the values builder.
ARROW_RETURN_NOT_OK(components_builder.Append());
- // Store the actual values. The final nullptr argument tells the underyling
+ // Store the actual values. The final nullptr argument tells the underlying
Review Comment:
Could you report this to the upstream?
https://github.com/conan-io/conan-center-index/blob/master/recipes/arrow/all/test_package/test_package.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
