paleolimbot commented on code in PR #38970:
URL: https://github.com/apache/arrow/pull/38970#discussion_r1410772512
##########
r/tools/nixlibs.R:
##########
@@ -295,32 +295,32 @@ determine_binary_from_stderr <- function(errs) {
if (is.null(attr(errs, "status"))) {
# There was no error in compiling: so we found libcurl and OpenSSL >= 1.1,
# openssl is < 3.0
- lg("Found libcurl and OpenSSL >= 1.1")
+ lg("Found headers for libcurl and OpenSSL >= 1.1")
Review Comment:
This was a request from me, since it more accurately describes the test that
just happens. Even though this output is visible to users we are the ones that
need it to debug their problem...I think "headers" is an acceptable tradeoff
between full verbosity and technical correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
