viirya commented on code in PR #8378:
URL: https://github.com/apache/arrow-datafusion/pull/8378#discussion_r1411302240
##########
datafusion/common/src/scalar.rs:
##########
@@ -50,9 +50,52 @@ use arrow::{
use arrow_array::cast::as_list_array;
use arrow_array::{ArrowNativeTypeOp, Scalar};
-/// Represents a dynamically typed, nullable single value.
-/// This is the single-valued counter-part to arrow's [`Array`].
+/// A dynamically typed, nullable single value, (the single-valued counter-part
Review Comment:
Not related to this PR, but I wonder why this is dynamically typed. Don't we
already know its type at compile time for a scalar e.g.,
`ScalarValue::Int32(Some(10))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
