paddyhoran commented on a change in pull request #9262: URL: https://github.com/apache/arrow/pull/9262#discussion_r560352119
########## File path: .github/workflows/rust.yml ########## @@ -109,14 +109,14 @@ jobs: export CARGO_HOME="/github/home/.cargo" export CARGO_TARGET_DIR="/github/home/target" cd rust - cargo test + # run tests on all workspace members + cargo test --all --features=prettyprint # test datafusion examples cd datafusion cargo run --example csv_sql cargo run --example parquet_sql cd .. cd arrow - cargo test Review comment: This was introduced when I was trying to test the SIMD and non-SIMD versions of the code. Feature options were not being respected within the sub-crates when supplied at the workspace level, see [here](https://github.com/rust-lang/cargo/issues/5015#issuecomment-532483775). So the solution was to move into the sub-crate to enable/disable the feature. Quickly reading through the cargo issues, it's not clear that this has been resolved yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org