jrevels commented on PR #493:
URL: https://github.com/apache/arrow-julia/pull/493#issuecomment-1841034744
> searched for `Struct{` and found a usage in
[arrow-julia/src/eltypes.jl](https://github.com/apache/arrow-julia/blob/787768fc60ff09ea52be0c5fb7c40e04be47619b/src/eltypes.jl#L530)
> does that need updating?
interesting. I *think* based on the docstring of `arrowtype`, this doesn't
need to be updated / is working as intended:
```
Given a FlatBuffers.Builder and a Julia column or column eltype, Write the
field.type flatbuffer definition of the eltype
```
if the intent of the function was to yield the actual flatbuffer definition
of the arrow data stored in the provided column, then actually we'd consider
this method buggy on `main` and this PR could fix it. but i don't think that's
the intent, so i think we're good as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
