wjones127 commented on code in PR #5170:
URL: https://github.com/apache/arrow-rs/pull/5170#discussion_r1416180395
##########
arrow-select/src/take.rs:
##########
@@ -689,7 +689,7 @@ fn take_value_indices_from_fixed_size_list<IndexType>(
where
IndexType: ArrowPrimitiveType,
{
- let mut values = vec![];
+ let mut values = Vec::with_capacity(length as usize * indices.len());
Review Comment:
On second thought, we should make this `PrimitiveBuilder`, since the
conversion from `Vec` is no longer zero-copy when it's an Option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
