pitrou commented on PR #39120: URL: https://github.com/apache/arrow/pull/39120#issuecomment-1845038685
This looks ok to me. Note this could probably be improved still. The silly part in this code is that we are generating a bitmap in `valid_bits`, then read it again bit by bit and append bit by bit into the final bitmap... The alternative would be to build the buffers separately (one `BufferBuilder` for the data and one `TypedBufferBuilder<bool>` for the null bitmap). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
