westonpace commented on code in PR #37298: URL: https://github.com/apache/arrow/pull/37298#discussion_r1419303692
########## cpp/src/arrow/acero/util_test.cc: ########## @@ -21,9 +21,12 @@ #include "arrow/testing/gtest_util.h" #include "arrow/testing/matchers.h" +#include "arrow/extension/uuid.h" Review Comment: Nit: You can remove the `#include "arrow/testing/extension_type.h"` import now. ########## cpp/src/arrow/extension/uuid.h: ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/extension_type.h" + +namespace arrow { +namespace extension { + +class ARROW_EXPORT UuidArray : public ExtensionArray { + public: + using ExtensionArray::ExtensionArray; +}; + +class ARROW_EXPORT UuidType : public ExtensionType { + public: + UuidType() : ExtensionType(fixed_size_binary(16)) {} + + std::string extension_name() const override { return "arrow.uuid"; } + + const std::shared_ptr<DataType> value_type() const { return fixed_size_binary(16); } + + bool ExtensionEquals(const ExtensionType& other) const override; + + std::shared_ptr<Array> MakeArray(std::shared_ptr<ArrayData> data) const override; + + Result<std::shared_ptr<DataType>> Deserialize( + std::shared_ptr<DataType> storage_type, + const std::string& serialized) const override; + + std::string Serialize() const override { return "uuid-serialized"; } Review Comment: Why can't we just serialize this as an empty string? ########## cpp/src/arrow/c/bridge_test.cc: ########## @@ -3694,7 +3695,10 @@ TEST_F(TestSchemaRoundtrip, Dictionary) { } TEST_F(TestSchemaRoundtrip, UnregisteredExtension) { - TestWithTypeFactory(uuid, []() { return fixed_size_binary(16); }); + TestWithTypeFactory(complex128, []() { Review Comment: It looks like you're removing uuid from a number of tests here. Why is that? ########## docs/source/format/CanonicalExtensions.rst: ########## @@ -251,6 +251,14 @@ Variable shape tensor Values inside each **data** tensor element are stored in row-major/C-contiguous order according to the corresponding **shape**. +UUID +==== Review Comment: I wonder if we should add a small note that we do not require any specific version of UUID. I.e. if a field is a UUID field then the user has no guarantee that it is UUIDv4 or v1 or it could even be mixed. ########## cpp/src/arrow/extension/uuid_test.cc: ########## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/extension/uuid.h" + +#include "arrow/testing/matchers.h" + +#include "arrow/array/array_nested.h" +#include "arrow/array/array_primitive.h" +#include "arrow/io/memory.h" +#include "arrow/ipc/reader.h" +#include "arrow/record_batch.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/util/key_value_metadata.h" + +#include "arrow/testing/extension_type.h" + +namespace arrow { + +using extension::uuid; + +class TestUuuidExtensionType : public ::testing::Test {}; Review Comment: Do we need a test fixture? ########## cpp/src/arrow/extension/uuid_test.cc: ########## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/extension/uuid.h" + +#include "arrow/testing/matchers.h" + +#include "arrow/array/array_nested.h" +#include "arrow/array/array_primitive.h" +#include "arrow/io/memory.h" +#include "arrow/ipc/reader.h" +#include "arrow/record_batch.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/util/key_value_metadata.h" + +#include "arrow/testing/extension_type.h" + +namespace arrow { + +using extension::uuid; + +class TestUuuidExtensionType : public ::testing::Test {}; + +TEST_F(TestUuuidExtensionType, ExtensionTypeTest) { Review Comment: ```suggestion class TestUuidExtensionType : public ::testing::Test {}; TEST_F(TestUuidExtensionType, ExtensionTypeTest) { ``` Minor nit: one too many u's -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
