alamb commented on PR #8447: URL: https://github.com/apache/arrow-datafusion/pull/8447#issuecomment-1858421598
🤔 I played around with this PR some this afternoon. I came to the same conclusion that we would have to make non trivial API changes to the expr_fn() APIs if we go the "must resolve string names to functions" as part of an analysis pass. The only other thing I can think of is to change the dependency structure Right now, the expr_fns are in the `datafusion_expr` crate We could potentially move them from `datafusion_expr` to a new crate (perhaps `datafusion_expr_fn`) that could rely directly on the built in function definitions 🤔 Let me give that a whirl to see how it would look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
