seddonm1 commented on a change in pull request #9243:
URL: https://github.com/apache/arrow/pull/9243#discussion_r562391973
##########
File path: rust/datafusion/src/physical_plan/functions.rs
##########
@@ -60,10 +59,15 @@ pub enum Signature {
// A function such as `array` is `VariadicEqual`
// The first argument decides the type used for coercion
VariadicEqual,
+ /// fixed number of arguments of vector of vectors of valid types
+ // A function of one argument of f64 is
`Uniform(vc![vec![vec![DataType::Float64]]])`
+ // A function of one argument of f64 or f32 is
`Uniform(vec![vec![vec![DataType::Float32, DataType::Float64]]])`
+ // A function of two arguments with first argument of f64 or f32 and
second argument of utf8 is `Uniform(vec![vec![vec![DataType::Float32,
DataType::Float64], vec![DataType::Utf8]]])`
+ Uniform(Vec<Vec<Vec<DataType>>>),
Review comment:
Yes. Agree. The existing code clearly took some thought so wanted to
leave it until we can agree correct course of action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
