Weijun-H commented on code in PR #8592:
URL: https://github.com/apache/arrow-datafusion/pull/8592#discussion_r1433037065


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1925,12 +1925,29 @@ pub fn array_length(args: &[ArrayRef]) -> 
Result<ArrayRef> {
 
 /// Array_dims SQL function
 pub fn array_dims(args: &[ArrayRef]) -> Result<ArrayRef> {
-    let list_array = as_list_array(&args[0])?;
+    let data = match args[0].data_type() {

Review Comment:
   I will address this later in the pull request as other functions may also 
lack this check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to