comphead commented on code in PR #8586:
URL: https://github.com/apache/arrow-datafusion/pull/8586#discussion_r1434316340
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -802,7 +802,7 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S> {
&& !info.get_data_type(&left)?.is_floating()
&& is_zero(&right) =>
{
- return
Err(DataFusionError::ArrowError(ArrowError::DivideByZero));
+ return plan_err!("Divide by zero");
Review Comment:
Thanks @alamb for this specific case I have doubled checked before
modification but there is no arrow kernel being called directly like in other
scenarios when `ArrowError` is thrown, that was the reason to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
