jayzhan211 commented on code in PR #8622:
URL: https://github.com/apache/arrow-datafusion/pull/8622#discussion_r1435413653
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -883,6 +899,10 @@ pub fn array_append(args: &[ArrayRef]) -> Result<ArrayRef>
{
/// Array_sort SQL function
pub fn array_sort(args: &[ArrayRef]) -> Result<ArrayRef> {
+ if args.is_empty() || args.len() > 3 {
Review Comment:
> I think we need to make it more usable in future for all built in
functions. To provide the exact available signatures, to let user quickly find
what is his mistake
@comphead
But we will also handle this while checking signature of array. Why do we
need to check it here again? Is there any usage that skip the signature
checking but jump to this call directly? If yes, we need to find a way to reuse
the checking because the coercion is not supported here currently, length
checking may not be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
