tustvold commented on code in PR #5247: URL: https://github.com/apache/arrow-rs/pull/5247#discussion_r1436638500
########## object_store/src/aws/dynamo.rs: ########## @@ -61,16 +63,24 @@ const STORE: &str = "DynamoDB"; /// /// The DynamoDB schema is as follows: /// -/// * A string hash key named `"key"` +/// * A string partition key named `"path"` +/// * A string sort key named `"etag"` /// * A numeric [TTL] attribute named `"ttl"` /// * A numeric attribute named `"generation"` /// * A numeric attribute named `"timeout"` /// -/// To perform a conditional operation on an object with a given `path` and `etag` (if exists), +/// An appropriate DynamoDB table can be created with the CLI as follows: +/// +/// ```bash +/// $ aws dynamodb create-table --table-name <TABLE_NAME> --key-schema AttributeName=path,KeyType=HASH AttributeName=etag,KeyType=RANGE --attribute-definitions AttributeName=path,AttributeType=S AttributeName=etag,AttributeType=S +/// $ aws dynamodb update-time-to-live --table-name <TABLE_NAME> --time-to-live-specification Enabled=true,AttributeName=ttl +/// ``` +/// +/// To perform a conditional operation on an object with a given `path` and `etag` (`*` if creating), Review Comment: DynamoDB doesn't let you use an empty string for a key attribute, so we use `*`, which is an illegal ETAG value (as If-Match wildcards would then be ambiguous) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
