alamb commented on code in PR #8594:
URL: https://github.com/apache/arrow-datafusion/pull/8594#discussion_r1438887493
##########
datafusion/expr/src/signature.rs:
##########
@@ -122,6 +122,9 @@ pub enum TypeSignature {
/// List dimension of the List/LargeList is equivalent to the number of
List.
/// List dimension of the non-list is 0.
ArrayAndElement,
+ /// Specialized Signature for ArrayConcat
+ /// Accept arbitrary arguments but they SHOULD be List/LargeList or Null,
and the list dimension MAY NOT be the same.
+ ArrayConcat,
Review Comment:
is there any usecase for this type of signature other than `ArrayConcat`? If
there is only a single function that would likely have this signature, the code
probably doesn't belong in the `TypeSignature` enum
I don't fully understand
> and the list dimension MAY NOT be the same.
For example, one of the tests is
```sql
select array_concat([1, null], [null]);
```
Doesn't that have two arguments of the same dimension?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
