alamb commented on code in PR #8721:
URL: https://github.com/apache/arrow-datafusion/pull/8721#discussion_r1442010934
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -336,9 +336,18 @@ where
}
fn size(&self) -> usize {
+ let estimated_buckets =
(self.values.len().checked_mul(8).unwrap_or(usize::MAX)
Review Comment:
maybe we can (as a follow on PR) put this logic into its own function (with
comments) as estimating the size of hashbrown hashtables is likely to come up
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
