Jefffrey commented on issue #8743: URL: https://github.com/apache/arrow-datafusion/issues/8743#issuecomment-1877855154
Also, worth fixing as well places which don't use the workspace rust-version, e.g. https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/docs/Cargo.toml#L18-L29 https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/benchmarks/Cargo.toml#L18-L27 https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/datafusion/core/Cargo.toml#L18-L30 https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/datafusion/proto/Cargo.toml#L18-L29 https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/datafusion/wasmtest/Cargo.toml#L18-L28 https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/datafusion/substrait/Cargo.toml#L18-L28 Or if theres a reason these should differ from what's specified in `Cargo.toml` then leave comments explaining this. Should ideally only have one place to specify: https://github.com/apache/arrow-datafusion/blob/e5036d0e760b637724e8ac59c32924f126311d39/Cargo.toml#L24-L32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
